Skip to content

Conversation

@turboFei
Copy link
Member

@turboFei turboFei commented Nov 1, 2025

Why are the changes needed?

Close #3866.

https://github.com/apache/hadoop/tree/trunk/hadoop-client-modules/hadoop-client-api and https://github.com/apache/hadoop/tree/trunk/hadoop-client-modules/hadoop-client-runtime are shaded to prevent conflicts.

Brief change log

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before making a pull request

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@turboFei turboFei changed the title Using hadoop-client-api and hadoop-client-runtime for hadoop3 [AMORO-3866] Using hadoop-client-api and hadoop-client-runtime for hadoop3 Nov 1, 2025
@turboFei turboFei changed the title [AMORO-3866] Using hadoop-client-api and hadoop-client-runtime for hadoop3 [AMORO-3866] Using shaded hadoop-client-api and hadoop-client-runtime for hadoop3 Nov 1, 2025
@turboFei turboFei closed this Nov 1, 2025
@turboFei turboFei reopened this Nov 1, 2025
@turboFei turboFei closed this Nov 1, 2025
@turboFei turboFei reopened this Nov 2, 2025
@turboFei turboFei force-pushed the hadoop_shaded branch 3 times, most recently from bc3c1b1 to 2741e29 Compare November 2, 2025 07:29
@turboFei turboFei closed this Nov 2, 2025
@turboFei turboFei reopened this Nov 2, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 22.13%. Comparing base (4382d55) to head (2704255).
⚠️ Report is 10 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (4382d55) and HEAD (2704255). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (4382d55) HEAD (2704255)
core 3 0
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #3865      +/-   ##
============================================
- Coverage     29.00%   22.13%   -6.87%     
+ Complexity     3850     2461    -1389     
============================================
  Files           631      444     -187     
  Lines         50770    40883    -9887     
  Branches       6543     5766     -777     
============================================
- Hits          14724     9050    -5674     
+ Misses        34989    31075    -3914     
+ Partials       1057      758     -299     
Flag Coverage Δ
core ?
trino 22.13% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@turboFei turboFei marked this pull request as draft November 2, 2025 20:19
@turboFei turboFei closed this Nov 2, 2025
@turboFei turboFei reopened this Nov 3, 2025
@turboFei turboFei changed the title [AMORO-3866] Using shaded hadoop-client-api and hadoop-client-runtime for hadoop3 [WIp][AMORO-3866] Using shaded hadoop-client-api and hadoop-client-runtime for hadoop3 Nov 3, 2025
@turboFei turboFei changed the title [WIp][AMORO-3866] Using shaded hadoop-client-api and hadoop-client-runtime for hadoop3 [WIP][AMORO-3866] Using shaded hadoop-client-api and hadoop-client-runtime for hadoop3 Nov 3, 2025
@github-actions github-actions bot added the module:ams-server Ams server module label Nov 10, 2025
@turboFei turboFei force-pushed the hadoop_shaded branch 3 times, most recently from 8940cd8 to f75ffb0 Compare November 13, 2025 06:14
@turboFei turboFei force-pushed the hadoop_shaded branch 2 times, most recently from 2178252 to 3eba67d Compare November 13, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Improvement]: Using hadoop-client-api and hadoop-client-runtime for hadoop3

2 participants